search

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products
http://honeycrisp.herokuapp.com
MIT License
26 stars 8 forks source link

Styleguide documentation requires calfresh_logo.png, which is missing #229

Closed hartsick closed 3 years ago

hartsick commented 3 years ago

Here's the line that references the file, which I think was removed because it was only relevant for GCF: https://github.com/codeforamerica/honeycrisp-gem/blob/1e95810bf07c564104d03abf4bf0b952bd2b8aee/app/views/examples/molecules/_media_box.html.erb#L4

Projects can host their own version of the styleguide documentation (see the routes mounting in the 'usage' section of documentation), which means that we should only reference files included in the gem in the docs.

To reproduce, add the following to the routes file of a host project that doesn't provide 'calfresh_logo.png' itself: mount Cfa::Styleguide::Engine => "/cfa"

hartsick commented 3 years ago

This is the same issue as https://github.com/codeforamerica/honeycrisp-gem/issues/250 but with less reproduction information. Closing in favor of other issue