search

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products
http://honeycrisp.herokuapp.com
MIT License
24 stars 8 forks source link

Remove double init of honeycrisp javascript. #248

Closed bytheway875 closed 3 years ago

bytheway875 commented 3 years ago

Thanks for a great bug report @lkogler @wschaefer -- when you said incrementor was incrementing by two, it seemed likely we were calling Honeycrisp.init() 2x, which was adding double listeners!

Honeycrisp.init() is also being called at the end of honeycrisp.js itself, so we don't need the call to Honeycrisp.init() in the manifest.

lkogler commented 3 years ago

Looks good to me and verified that it fixes the issue!