search

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products
http://honeycrisp.herokuapp.com
MIT License
24 stars 8 forks source link

Add calfresh_logo.png to precompiled assets #258

Closed hartsick closed 2 years ago

hartsick commented 3 years ago

It's needed for host applications if they mount /cfa/styleguide, since it's used in the styleguide documentation page. This should prevent host applications from getting a 500 error for missing precompiled assets, which is currently happening on GYR and CGLA.

There are likely more robust solutions, but this is the one I've got 🤷.

Closes #250

To test in host project:

  1. Reproduce: In development.rb and with gem on current master, add the following configuration:

    config.assets.check_precompiled_asset = true

    Boot up dev server and visit /cfa/styleguide. See error.

  2. Test this fix: Update Honeycrisp gem to this branch (In Gemfile, set gem 'cfa-styleguide', git: 'https://github.com/codeforamerica/honeycrisp-gem', ref: '6ca7ac9', bundle install). Restart dev server

Visit /cfa/styleguide. See no error

bengolder commented 3 years ago

@hartsick I tried to spin it up locally, and I seem to be getting a different error. I'm not sure if it's related or is a problem specific to GYR. I know there were recent changes to JS asset compilation.

The asset "application.js" is not present in the asset pipeline.

hartsick commented 3 years ago

okay sounds good. thanks for checking! I suspect something is off about how we’re expecting the asset pipeline to work in our test application and both the thing you found and the thing I was trying to quickly address are a symptom of that

hartsick commented 3 years ago

since the calfresh_logo.png problem is currently preventing local test runs and is breaking our hosted applications, I'd like to merge without addressing the JS problem just because it doesn't seem like we have the bandwidth to consider another approach.

I'm also not sure they're related, or if the problem is specific to GYR since we haven't seen anything else. @bengolder could you open a different issue for the JS problem you're seeing if that proposal sounds okay to you?

hartsick commented 2 years ago

trying to clean up my personal PR workspace in Github so going to close this for inactivity! hi everyone!