search

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products
http://honeycrisp.herokuapp.com
MIT License
24 stars 8 forks source link

Namespace honeycrisp SCSS files for easy overrides #261

Closed hartsick closed 3 years ago

hartsick commented 3 years ago

Based on investigation, every project that currently uses Honeycrisp imports the SCSS as one file, cfa_stylguide_main.scss, so I don't think this should have any negative impact on projects. Have confirmed by testing in CMR.

Would like to do the same with Javascript and images, but since those changes would potentially be breaking, want to keep as separate issue.

For more context on why this is useful, see linked issue below.

Closes #260

Possible improvement/future Adding a file honeycrisp/_honeycrisp.scss that can be imported as honeycrisp/honeycrisp that would load in all "official" honeycrisp SCSS. This would replace cfa_styleguide_main.scss and would allow us to more clearly define what is a part of the official library (vs is just in the gem for historical reasons)

hartsick commented 3 years ago

@ericwbailey this is a really great suggestion! I hadn't known about the new sass module system; seems exciting. Will create an issue so we can discuss in future.