codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products
http://honeycrisp.herokuapp.com
MIT License
24 stars 8 forks source link

Center content for document pages #272

Closed bengolder closed 3 years ago

bengolder commented 3 years ago

For upload documents and document recommendation, card is moved over and not centered

Small style discrepancy we encountered when upgrading SHIBA to the latest version of Honeycrisp

Percy failures

coltborg commented 3 years ago

This is happening because .grid-ignore-mobile doesn't have margin-left: auto; margin-right: auto; defined anymore.

~I think it has something to do with neat being pulled out and placed in the vendor folder.~

coltborg commented 3 years ago

Page was not centering correctly because .grid-ignore-mobile was used only in SHIBA and not Honeycrisp. To fix the issue we added .grid-ignore-mobile to the css file in SHIBA. Custom code originally in honeycrisp.css that we moved to shiba.css