Fix icons - Githubissues

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products

http://honeycrisp.herokuapp.com

MIT License

24 stars 8 forks source link

Fix icons #273

Closed bengolder closed 3 years ago

bengolder commented 3 years ago

Small style discrepancy we encountered when upgrading SHIBA to the latest version of Honeycrisp

Percy failures

[x] Arrow button is gone
[x] intercom button icon positioning is a little different -> it looks better now
[x] + icon position is slightly off -> it looks better now
[x] lock icon position is slightly -> it looks better now
[x] -> icon position is slightly -> is svg instead of material icon, moved it back into it's previous place

coltborg commented 3 years ago

Dropdown icons were missing because Shiba reference the font family MaterialIcons-Regular instead of Material Icons and an override wasn't added for .select:after.

Icon position shift was happening because Honeycrisp introduced a small vertical alignment change for icons.

We kept this vertical change for Material icons and removed it for SVG icons.