Fix reveal component - Githubissues

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products

http://honeycrisp.herokuapp.com

MIT License

24 stars 8 forks source link

Fix reveal component #275

Closed bengolder closed 3 years ago

bengolder commented 3 years ago

Reveal’s hard hidden on page load with .is-hidden class on the wrong element.

It looks like the reveal does not have a unit test and has a breaking change with 0.10.2

In the documentation, the entire reveal component is incorrectly hidden on page load, when it should only be hiding the additional details.

coltborg commented 3 years ago

When did the reveal disappear? - v0.10.1

coltborg commented 3 years ago

This issue is coming from a new CSS definitaion of .is-hidden for form builder to use, when reveal was using that same class name to hide a nested element. This can be resolved with changing the reveal class name.

coltborg commented 3 years ago

[x] Change .reveal.is-hidden class name to not use .is-hidden
[x] Add tests to cover reveal component