Move certain variables from settings.py to configuration variable

codeforamerica / mdc-feedback

[MDC Fellowship 2015] RER Dashboard & Feedback Engine

http://mdc-feedback-stage.herokuapp.com/

MIT License

4 stars 6 forks source link

Move certain variables from settings.py to configuration variable #515

Closed ErnieAtLYD closed 9 years ago

ErnieAtLYD commented 9 years ago

The Gmail development e-mail address and passwords should be moved from settings.py to a configuration variable.
The API keys (Typeform) should be moved from a settings.py file to a configuration variable as well.

ErnieAtLYD commented 9 years ago

@phiden and @mathias, note that once I produce a fix for this bug you will have to add two environmental variables, MAIL_USERNAME and MAIL_PASSWORD. Ask Ernie for the values. Sophia, you will need to add this to $VIRTUAL_ENV/bin/postactivate file.

phiden commented 9 years ago

Ok, please advise it’s fixed

On Mon, Nov 9, 2015 at 2:08 PM, Ernie Hsiung notifications@github.com wrote:

@phiden and @mathias, note that once I produce a fix for this bug you will have to add two environmental variables, MAIL_USERNAME and MAIL_PASSWORD. Ask Ernie for the values. Sophia, you will need to add this to $VIRTUAL_ENV/bin/postactivate file.

Reply to this email directly or view it on GitHub: https://github.com/codeforamerica/mdc-feedback/issues/515#issuecomment-155214565

mathias commented 9 years ago

I think you meant @mathias-gibson so sending him a notification ;)

phiden commented 9 years ago

No, I meant you, @ernieatlyd — please advise when fixed so I can add the vars to the $VIRTUAL_ENV.:)

On Mon, Nov 9, 2015 at 2:16 PM, Matt Gauger notifications@github.com wrote:

I think you meant @mathias-gibson so sending him a notification ;)

Reply to this email directly or view it on GitHub: https://github.com/codeforamerica/mdc-feedback/issues/515#issuecomment-155216470

ErnieAtLYD commented 9 years ago

(But I meant @mathias-gibson, yeah. Apologies! Stupid auto-complete.)

phiden commented 9 years ago

ohhh. What I get for not looking at the sender of the original message ;)

On Mon, Nov 9, 2015 at 3:02 PM, Ernie Hsiung notifications@github.com wrote:

(But I meant @mathias-gibson, yeah. Apologies! Stupid auto-complete.)

Reply to this email directly or view it on GitHub: https://github.com/codeforamerica/mdc-feedback/issues/515#issuecomment-155226675

codeforamerica / mdc-feedback

Move certain variables from settings.py to configuration variable #515

@phiden and @mathias, note that once I produce a fix for this bug you will have to add two environmental variables, MAIL_USERNAME and MAIL_PASSWORD. Ask Ernie for the values. Sophia, you will need to add this to $VIRTUAL_ENV/bin/postactivate file.

I think you meant @mathias-gibson so sending him a notification ;)

(But I meant @mathias-gibson, yeah. Apologies! Stupid auto-complete.)

@phiden and @mathias, note that once I produce a fix for this bug you will have to add two environmental variables, `MAIL_USERNAME` and `MAIL_PASSWORD`. Ask Ernie for the values. Sophia, you will need to add this to `$VIRTUAL_ENV/bin/postactivate` file.