search

codeforamerica / naics-api

Basic API to return NAICS codes and information
BSD 3-Clause "New" or "Revised" License
96 stars 55 forks source link

Store data in a database format (not flat-file JSONs) #10

Closed louh closed 11 years ago

louh commented 11 years ago

pinging @daguar @rclosner @ycombinator for recommendations.

lovehandle commented 11 years ago

Not a bad idea, but I would like to hear the reasoning why. Dependent upon what you're looking to do, it might make more sense to keep the API reliant upon flat JSON files.

ycombinator commented 11 years ago

+1 @rclosner. What's the use case? That should drive the technology decision.

louh commented 11 years ago

Briefly mentioned in a discussion here: https://github.com/dobtco/NAICS/issues/1

So far the flat version works fine, but I was under the impression that if it got too large then having a database is the way to go for speed, etc. I thought I could head it off by getting it started early, but I'm okay with not doing this until someone who knows more about this than I do points out when/if it is necessary.

On Tue, Jun 4, 2013 at 5:17 PM, Shaunak Kashyap notifications@github.comwrote:

+1 @rclosner https://github.com/rclosner. What's the use case? That should drive the technology decision.

— Reply to this email directly or view it on GitHubhttps://github.com/louh/naics-api/issues/10#issuecomment-18948084 .

Lou Huang 2013 Fellow, Code for America / San Francisco / Las Vegas lou@codeforamerica.org | 510.364.0641 | @saikofishhttp://twitter.com/saikofish | louhuang.com http://www.louhuang.com/

daguar commented 11 years ago

YAGNI

On Jun 4, 2013, at 5:23 PM, Lou Huang notifications@github.com wrote:

Briefly mentioned in a discussion here: https://github.com/dobtco/NAICS/issues/1

So far the flat version works fine, but I was under the impression that if it got too large then having a database is the way to go for speed, etc. I thought I could head it off by getting it started early, but I'm okay with not doing this until someone who knows more about this than I do points out when/if it is necessary.

On Tue, Jun 4, 2013 at 5:17 PM, Shaunak Kashyap notifications@github.comwrote:

+1 @rclosner https://github.com/rclosner. What's the use case? That should drive the technology decision.

— Reply to this email directly or view it on GitHubhttps://github.com/louh/naics-api/issues/10#issuecomment-18948084 .

Lou Huang 2013 Fellow, Code for America / San Francisco / Las Vegas lou@codeforamerica.org | 510.364.0641 | @saikofishhttp://twitter.com/saikofish | louhuang.com http://www.louhuang.com/ — Reply to this email directly or view it on GitHub.

louh commented 11 years ago

I had to look that up.

Thanks, everyone.