search

codeforamerica / oakland_answers

Code For America's version of Oakland Answers.
10 stars 15 forks source link

Feature/fix category index view #71

Closed adelevie closed 10 years ago

pui commented 10 years ago

Please rebase.

jgrevich commented 10 years ago

And please post any ?'s about Gemfile/Gemfile.lock merges in the slack channel or in the PR threads.

adelevie commented 10 years ago

Gemfile.lock has a merge conflict when I rebase. What do I do?

adelevie commented 10 years ago

Rebased, but I think tests will fail like so:

Failures:

  1) RailsNlp::TextAnalyser Clean the text of non-word characters removes non-valid html FIXED
     Expected pending 'not working since the hml tokenizer in actionpack only supports valid xhtml' to fail. No Error was raised.
     # ./spec/lib/rails_nlp_spec.rb:62

  2) RailsNlp::TextAnalyser Given an array of words, return an array of Keywords uses an existing keyword if one is present FIXED
     Expected pending 'not sure how to test' to fail. No Error was raised.
     # ./spec/lib/rails_nlp_spec.rb:130

  3) RailsNlp::TextAnalyser Given an array of words, return an array of Keywords creates a new keyword if one doesn't already exist FIXED
     Expected pending 'not sure how to test' to fail. No Error was raised.
     # ./spec/lib/rails_nlp_spec.rb:135
adelevie commented 10 years ago

pinging @hale for insight