search

codeforamerica / ohana-api

The open source API directory of community social services.
http://ohana-api-demo.herokuapp.com/api
BSD 3-Clause "New" or "Revised" License
185 stars 344 forks source link

Update setup_heroku script #418

Closed md5 closed 7 years ago

md5 commented 7 years ago

This PR updates the setup_heroku script with the following improvements:

  1. Stop provisioning DEVISE_SECRET_KEY since a separate setting for Devise is not needed with modern versions of Devise and Rails 4+ (cf. https://github.com/plataformatec/devise/pull/2835). The devise.rb initializer has been updated to allow the application to start without ENV['DEVISE_SECRET_KEY'], in which case Devise will use Rails.application.config.secret_key_base (controlled by ENV['SECRET_TOKEN'])
  2. Allow the script to be run idempotently
    • Check if a Heroku add-on is installed before calling heroku addons:create
    • Check if SECRET_TOKEN is set before generating one
  3. Use Ruby instead of Python for UUID generation, since this is a Ruby-based project
  4. Add quotaguard:starter addon (cf. #415)
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling aa78063b913be8d8ea0d588892265b0e485326a9 on appropriate:update-setup-heroku-script into f0e17d35d39b6e70f9ec7df7b65ebe8de128a5e0 on codeforamerica:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling 2d7c28575ef81c67f3d6972cc57d1e8ed488c43f on appropriate:update-setup-heroku-script into f0e17d35d39b6e70f9ec7df7b65ebe8de128a5e0 on codeforamerica:master.

monfresh commented 7 years ago

lgtm. Please squash the commits and include your original PR comment in the commit message to explain the changes. Thanks!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling ae47886ad9943f5df48b324676c1526dba1116f4 on appropriate:update-setup-heroku-script into e337b7e84e16dde5e836b58de8be3cb1cba460a1 on codeforamerica:master.

md5 commented 7 years ago

@monfresh squashed and amended to include my PR comment in the commit

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling ae47886ad9943f5df48b324676c1526dba1116f4 on appropriate:update-setup-heroku-script into e337b7e84e16dde5e836b58de8be3cb1cba460a1 on codeforamerica:master.