search

codeforamerica / ohana-api

The open source API directory of community social services.
http://ohana-api-demo.herokuapp.com/api
BSD 3-Clause "New" or "Revised" License
185 stars 344 forks source link

Update gems #423

Closed md5 closed 7 years ago

md5 commented 7 years ago

This PR updates Ohana API's dependencies using bummr. One update that bummr ended up dropping was the update from protected_attributes 1.1.3 (July 2015) to 1.1.4 (May 2017). I didn't dig into that failure, so I'm not sure what that's all about.

There are a couple of major version upgrades here, specifically ancestry 2.2.2 to 3.0.0 and haml-rails 0.9.0 to 1.0.0. Looking at the changelog for ancestry, it looks like the major version bump was motivated by dropping support for older versions of Rails. I don't see any breaking changes mentioned that are relevant to Ohana. For haml-rails, it looks like they just decided it was time to call it "1.0"; I don't think any breaking changes were involved.

Included in these updates (specifically in bef6d7ca) is an update for nokogiri, which resolves an open alert on Gemnasium. The alert is related to libxslt, however, so I don't think it has any actual relevance for Ohana API (see https://github.com/sparklemotion/nokogiri/issues/1634).

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling 2a72d410d4ccc7fff5b73e768a5bf460f5cff609 on appropriate:update-gems into 802ad1e11adb85aecbabaa9c2b16b4a366791963 on codeforamerica:master.

monfresh commented 7 years ago

Thanks!