search

codeforamerica / ohana-pdf

Generator for PDFs from the Ohana API
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

api2pdf gem #5

Open rebyn opened 11 years ago

rebyn commented 11 years ago

Just published the gem here. Shall we go ahead and plug it into the main app? Lemme know your thoughts :-).

Cheers, Tu.

anselmbradford commented 11 years ago

@rebyn Thanks for your work on this :) We're just in the midst of mid-year reporting time, so probably won't be able to look at the integration till the middle of the coming week. It's also still an outstanding question of how to set up the processing chain between generating a PDF and querying the API (from the discussion at https://github.com/codeforamerica/human_services_finder/issues/93), which hopefully will get addressed this coming week as well.

One thing I'd suggest though is that for the time being we include the PDF project via directly accessing the repository, not through a published gem. This is because the API is still very much in development so there will likely need to be significant updates to all dependencies in the coming weeks:

gem 'api2pdf', :git => "https://github.com/codeforamerica/ohana-pdf.git", :branch => 'master'

rebyn commented 11 years ago

OK then. So in the meantime I'll work on adding the gem on github to the app, and uploading the PDFs to S3.