search

codeforamerica / ohana-web-search

A mobile-friendly website for finding human and social services in your community
http://ohana-web-search-demo.herokuapp.com
BSD 3-Clause "New" or "Revised" License
69 stars 74 forks source link

Map marker icons should use a sprite sheet #350

Open anselmbradford opened 10 years ago

anselmbradford commented 10 years ago

Currently the marker icons in https://github.com/codeforamerica/ohana-web-search/tree/master/app/assets/images/markers are individual files. These should use a sprite sheet instead so that all markers are loaded in one file and markers are specified per coordinates in the sprite sheet (see http://stackoverflow.com/questions/13785226/google-map-marker-sprite-image-position for an example).

The map markers are used on the results map as well as on the results entries and detail pages upper-left corner:

screen shot 2014-03-28 at 12 09 26 pm

monfresh commented 10 years ago

Before anyone spends time on this, we first need to determine whether or not the "Kind" attribute is something other communities would have use for. "Kind" mainly came out of the fact that the SMC data contained more than just human services.

I would duplicate this issue in the SMC repo and move the "hack request" label from here to there.

anselmbradford commented 10 years ago

Being able to differentiate the results on the map by some visual cue is beneficial. That may not be the "Kind" attribute (e.g. it might be OE categories), but having the legwork in place to be able to show different icons is a good idea, so I think this issue is fine to proceed on. Which icons map to which criteria would be a separate issue.

I'd prefer the work be done here and then rolled over to smc-connect unless there's value in having the issue duplicated across both repos.

anselmbradford commented 10 years ago

As mentioned in https://github.com/codeforamerica/ohana-web-search/pull/382, spritesheet will only contain one image at this time, but this sets the groundwork for adding more markers and delivering them as a spritesheet.

anselmbradford commented 10 years ago

It would be nice to be able to use Compass automatic spriting, but it seems difficult/not possible to specify the sprite coordinates for the markers using CSS classes (at least without a hackish approach).

civicissuebot commented 9 years ago

Hello! This issue looks like it still needs help! It's been clicked on 11 times through the Civic Issue Finder on http://www.codeforamerica.org/. Can this issue be closed or does it still need some assistance?

If you wrote this issue, you can always update the labels for specifying tasks, add more info in the description to make it easier to contribute, or re-write the title to make more contributors interested in helping out. If you are an open source contributor, ask and see how you can help by commenting or check out more open issues in this repo at https://github.com/codeforamerica/ohana-web-search/issues.

Just doing a little :seedling: open source gardening :seedling: of Brigade projects! For more info/tools for creating civic issues, check out Got Issues Thank you!