Open anselmbradford opened 10 years ago
Hello! This issue looks like it still needs help! It's been clicked on 18 times through the Civic Issue Finder on http://www.codeforamerica.org/. Can this issue be closed or does it still need some assistance?
If you wrote this issue, you can always update the labels for specifying tasks, add more info in the description to make it easier to contribute, or re-write the title to make more contributors interested in helping out. If you are an open source contributor, ask and see how you can help by commenting or check out more open issues in this repo at https://github.com/codeforamerica/ohana-web-search/issues.
Just doing a little :seedling: open source gardening :seedling: of Brigade projects! For more info/tools for creating civic issues, check out Got Issues Thank you!
The floating header kicks in when the scrolling has reached the top of the floating header. However, when the static vs the floating header are different heights, this can lead to a gap of white space above the content directly below the header.
Static header:
Floating header:
To Fix I believe this would be the solution: The floating header should kick in when the scroll bar has reached a position equal to the bottom of the static header minus the height of the floating header. The floating header is managed by https://github.com/codeforamerica/ohana-web-search/blob/master/app/assets/javascripts/search/header-manager.js