search

codeforamerica / ohana-web-search

A mobile-friendly website for finding human and social services in your community
http://ohana-web-search-demo.herokuapp.com
BSD 3-Clause "New" or "Revised" License
69 stars 74 forks source link

Drop support for IE 8 and 9 and remove unused code #982

Closed monfresh closed 2 years ago

monfresh commented 2 years ago

The CodeQL security analysis was flagging code in util.js that turned out to be unused. It was related to the Google translate feature that was removed a while back.

CodeQL was also flagging selectivizr.js, which is only used to support IE 8 and 9. However, those browsers are not supported anymore by Microsoft, and recent visitor analytics for smc-connect.org show that no one is using IE at all.

Google Maps also does not support those old versions of IE, and displays a warning that recommends using a different browser.

All of the files in the vendor folder were only used to support IE 8 and 9, so we can remove them all.

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit a467d429 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.4% (0.0% change).

View more on Code Climate.