Replace tasks.py with pdftk_wrapper.py

codeforamerica / pdfhook

A Python web application for converting PDF forms into PDF-filling APIs

https://pdfhook.herokuapp.com

MIT License

46 stars 24 forks source link

Replace tasks.py with pdftk_wrapper.py #52

Closed bengolder closed 8 years ago

bengolder commented 8 years ago

Changes:

deleted tasks.py
post_pdf returns a new format (see test_sample_pdfhook.py for an example) that shows the options available on radios and checkboxes.
fill_pdf fills checkboxes.
cleaning up tmp files is still done in the post_request hook, but is handled by pdftk_wrapper, which maintains a list of all created temp files.

Addresses #51

coveralls commented 8 years ago

Coverage increased (+8.2%) to 92.593% when pulling 54def49204f87689901c650ff54f69d48f13712f on refactor_tasks into 1f62149682ef7ad4e4f6df33be7a4dbef0145061 on master.

bengolder commented 8 years ago

I'm gonna merge this. But @gauravmk you should review and make sure these changes are cool with you. If not we can revert.