Add delete buttons - Githubissues

codeforamerica / pdfhook

A Python web application for converting PDF forms into PDF-filling APIs

https://pdfhook.herokuapp.com

MIT License

46 stars 24 forks source link

Add delete buttons #77

Closed brennv closed 8 years ago

brennv commented 8 years ago

Adds "Delete" to the main page rows, marks the record as archived and filters from view.

coveralls commented 8 years ago

Coverage decreased (-2.6%) to 89.251% when pulling 79bb203e0f27a72c3b25c422e4dd2cfe2a32d71b on brennv:add-delete-buttons into aa7eb50c654fb79ca3e5c9e95a3c3b8db58aac90 on codeforamerica:master.

coveralls commented 8 years ago

Coverage decreased (-1.5%) to 90.429% when pulling 1c6db1957f26f7de4ce5db399f0ee53f731adf5c on brennv:add-delete-buttons into aa7eb50c654fb79ca3e5c9e95a3c3b8db58aac90 on codeforamerica:master.

bengolder commented 8 years ago

@brennv and I just talked in person.

This is a great move, but I want to add some changes to this branch before merging:

have an actual delete (not archive) that can be accessed from the API. This is based on the assumption that are target users are developers and the core use case should assume admin privileges via an API.
have a test to prevent future regression on this feature.

coveralls commented 8 years ago

Coverage decreased (-1.5%) to 90.429% when pulling 955fec574c46cc17893f9e581d32b68ca22ed24d on brennv:add-delete-buttons into 5eaa8e0caae78f27d8fb8eb6e1e5ff11b0c0d665 on codeforamerica:master.