codeforamerica / pittsburgh-purchasing-suite

https://www.buildpgh.com/
BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

[WIP] DO ALL TEH DOCS #573

Closed hamhands closed 8 years ago

hamhands commented 8 years ago

To do:

giphy 26

bsmithgall commented 8 years ago

Docs-dev dos available here

tmaybe commented 8 years ago

I tried following the installation instructions and hit a couple snags:

  1. I think you should say explicitly that the developer needs to change into the repo directory, as you do in the More detailed installation instructions.
  2. I think you should also say explicitly that the developer should pip install -r requirements.txt, even though that instruction's contained in the linked how-to.
  3. Running make setup as instructed fails because Sphinx is required but isn't in requirements.txt. I installed it manually.
  4. After that, the make started, but failed at bower install with this error:
bower install
make[1]: bower: No such file or directory
make[1]: *** [install] Error 1
make: *** [setup] Error 2

I didn't try to diagnose that one.

bsmithgall commented 8 years ago

@tmaybe Thanks! 1-3 should all be fixed now. I added 1, and 2-3 can now be handled via make setup as before. There was an issue with importing the sphinx makefile where it was executing some bash on every call into the makefile. I moved that into a function and am calling the function on any make script that involves sphinx instead.

With 4, it's a bit tricker. The bower home page says that you need to use npm install -g, which involves a global install. I will investigate on a clean install if we can get away with just installing bower into the local dependencies via node_modules.

bsmithgall commented 8 years ago

This is ready to go I think!

msknee commented 8 years ago

:+1: