search

codeforamerica / pittsburgh-purchasing-suite

https://www.buildpgh.com/
BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

External link tooltip #588

Closed hamhands closed 8 years ago

hamhands commented 8 years ago

What changed

external

msknee commented 8 years ago

:+1:

bsmithgall commented 8 years ago

It would be really great if you could add a new setting in the settings file that would make the classes conditional on some configuration setting through the environment. That way when we finally do move all the way over to the pittsburghpa.gov, we can just flip a switch to make it go instead of merging this now and having them appear on buildpgh.com and/or having to wait until we are live to merge this.

bsmithgall commented 8 years ago

@hamhands great! as a last thing, can you add a docstring for the new filter function and then rebase to fix up some of your commits?

bsmithgall commented 8 years ago

Overall looks good, just two minor things in comments.

Also, I think it would be good for this to be configurable from the environment, so that it will be easy to change on Heroku. Take a look at the BROWSERID_URL for an example.

hamhands commented 8 years ago

Ok I think we're good to go now!?!?!?!?

bsmithgall commented 8 years ago

@hamhands is it ok if i resolve the potential merge conflicts?

hamhands commented 8 years ago

@bsmithgall :+1:

hamhands commented 8 years ago

giphy 25