codeforamerica / pittsburgh-purchasing-suite

https://www.buildpgh.com/
BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

Sort/Color by Expiration date does not work in conductor #616

Closed rileystewart closed 8 years ago

rileystewart commented 8 years ago

I am trying to sort by expiration date to see the contracts that expired the longest time ago. This is not working. Also I believe the color coding for the expiration date column was supposed to be based on if the contract was expired (aka if the contract has already expired it's red, if its within 90 days of expiration it's yellow). Currently it is just whatever color the 'Current Step Started' is in

bsmithgall commented 8 years ago

Fixed by https://github.com/CityofPittsburgh/pittsburgh-purchasing-suite/pull/3

@rileystewart you can open issues over there now as well

bsmithgall commented 8 years ago

As for the colors, this was the design decision reached a long time ago when we were first doing the conductor mockups. It can be changed, but it would be good to make sure that that is in line with what Ed & @dormansteph need.