search

codeforamerica / resident-web-use-research

[work in progress] Digital Front Door survey tool for resident research
8 stars 4 forks source link

Updates to CR API call and other methods to restore functionality #34

Open rossettistone opened 8 years ago

rossettistone commented 8 years ago

Details available at https://github.com/censusreporter/census-api/issues/36

@migurski This should fix the broken endpoint. Still running into a number of other problems, though, that are preventing the page from loading. Would love to talk through those for 30 mins if you have time.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 57.349% when pulling b497c793daf3b5f5ffed3f00514dee414c7007cc on rossettistone:api-fix into 9d8ecf8e89d26b6e4de3ac30d745ee00a0bc10e1 on codeforamerica:master.

milafrerichs commented 8 years ago

maybe I can help too. Would love to see the project move on and see use cases for it.

rossettistone commented 8 years ago

That would be wonderful, @milafrerichs! Would love to chat over Slack or jump on a call. Just LMK.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 57.349% when pulling 9342259bfbe1858eb8e1dbf68c084dd71fd057d5 on rossettistone:api-fix into 9d8ecf8e89d26b6e4de3ac30d745ee00a0bc10e1 on codeforamerica:master.

rossettistone commented 8 years ago

@milafrerichs Any chance you could have a look at the three failing tests? I think the changes to the code conflicted with the test mocks, but I can't seem to get to the bottom of it...

milafrerichs commented 8 years ago

it's just one line change: in survey-resultsSpec.js line 27.

this.build_map = { init: function(e,d) {}, addControl: function(c) {} };

instead of 

var map = { addControl: function(c) {}};
this.build_map = { init: function(e,d) {}, data: data, map: map };
rossettistone commented 8 years ago

Thanks! You're absolutely right - I just wasn't seeing it for some reason :-)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 57.246% when pulling 0a3607c4862f2374961d0dca23f91008fe3dcd36 on rossettistone:api-fix into 9d8ecf8e89d26b6e4de3ac30d745ee00a0bc10e1 on codeforamerica:master.