user testing bugs, October visit

[mapsam]

Day 1

• [x] typing in other SSN & birthday fields resulted in the "Add New Patient" button disappearing after some time, something about Defiant.js searching multiple values is messed up. Will dig into it, and also considering writing our own JSON.search() extension since we are only using that single piece of Defiant.js. I can't recreate this bug, anyone else?
• [x] date picker is weird when you have to choose new years - let's look into making dates with three separate inputs a la USDS
• [x] make dropdowns for phone description
• [x] make dropdowns for address description
• [ ] make dropdowns for household individual relationship
• [x] dropdown for "how long have you worked here?"
• [x] years at current employer breaks when you enter 0 years
• [x] phone numbers without dashes are marked as invalid (javascript) but save properly (backend)
• [x] saving "new patient" resulted in a db break due to some malformed many-to-one fields - every save resulted in new, empty rows (fixed in #250)
• [x] still seems to be a bit of confusion when a user wants to navigate back to the index page. "Search patients" doesn't seem obvious right away. Maybe add "Home page" link & have logo link back to home. Update: changed the button to "Home" with a house icon
• [ ] referral buttons aren't terribly obvious, let's make them BETTER
• [x] carry info from index search into create new patient
• [x] save button on patient details only appears when you scroll down far enough below the patient header

  Day 2

• [x] CRITICAL: IE doesn’t show any results from search on index page (let’s build with jQuery instead of document.create…)
• [ ] no edit/delete buttons on IE for many-to-one forms
• [ ] fontawesome is failing miserably on IE (look at IE 8 caveats and IE9+ OTF/TTF troubshooting)
• [x] placeholder in prescreener monthly income is incorrect (woops :frowning:)
• [x] header on IE is huge, bulky, wtf (I think this is related to media queries and our mobile menu. I'm not particularly sold on the swipe menu in the app, so it might be worth getting rid of it for simplicity's sake)
• [x] information for all referrals and service eligibility checks on "review & send" should show up so the user can see same information from the referral history page
• [x] Does Patient have insurance? Yes, with VCC doesn't make sense since VCC is not technically insurance. We should phrase this differently.
• [x] similarly, when the questions have not been asked, put "no answer" on these fields.
• [ ] there is no page success/error notification when someone submits referral confirmation/denial
• [x] notifications are borked on ie
• [x] strong tags not appearing on ie9
• [x] checkboxes for race (instead of having to choose one)
• [x] checkboxes for language

  Day 3

Testing with Shikita on dropdowns-not-dropfrowns branch.

• [ ] referral page shows the current user’s service - we should just remove this, or style it differently
• [x] Seems like most people think the referral history page is about appointments, rather than referrals
• [ ] Not eligible boxes look borked - just a grey button. We want to make these boxes much more clear - but still allow them to send referrals
• [x] There is a lot of information in the referral boxes right now after a referral was made to Daily Planet - was a bit confusing to Kita
• [ ] Kita was really into the idea of having notes, we’ve talked about adding ad hoc “notes” pieces about patients that users could use to track their own ideas
• [x] Are fields required when making a new patient on the search page?
• [x] Date formatting in the search fields is not the best YYYY-MM-DD isn’t very intuitive
• [ ] Access Now questions about income should only show up if the individual does not have any income
• [x] Validation error on monthly amount (income sources) after deleting the value and leaving it blank - it should have nothing
• [x] Default for prescription drugs is “YES” it should be blank
• [ ] After you save the original new patient, there is no confirmation that says you have saved this patient
• [ ] “Likely eligible for Access Now” doesn’t have a referral button even though the patient is eligble - patient is named Shana Thompson on Sam’s local database, so we can debug that
• [ ] The “send referral” page just needs some major reworking - it doesn’t make a lot of sense to people
• [ ] patient edit history initial save is every field - might be worth just saying which fields were filled out, rather than all fields with blank entries
• [x] similarly - let’s build these into lists of changes rather than a bunch of line breaks - will make a lot clearer

  Day 4

• [ ] document upload many-to-ones could use some styling

Access Now

• [x] Icons in notifications are pretty dull - let’s brighten them up
• [x] Information is a bit crammed on the screen - want to check if they are zoomed in
• [ ] be able to mark who is making the income under household income - this would help for determining the full household income
• [ ] How long have you been unemployed is numbers, how long have you been employed is a dropdown - let’s match them
• [x] Validation on date fields didn’t fix when they used the date selector
• [x] Arrows on the overview notification pointing down the page are helpful
• [x] Forever ineligible mark (similar as archiving a patient?)
• [x] Deleting many-to-one rows doesn’t trigger a dirty form - want to do this on anything changing, not just a field
• [x] Pressing delete on many-to-one removes the row, but doesn’t save in the DB without pressing save - might want to mark these as “prepared to be removed” instead of hiding them completely
• [ ] File upload bug “no getValue” error https://gist.github.com/mapsam/4b38000c4dec351d5c16
• [ ] n/a sliding scale should be hidden if the service has no sliding scale
• [x] overflowing content in the edit history: http://rva-screener.on-aptible.com/patient_history/5
• [ ] emails should point to patient overview page, not patient details
• [x] Service profile page: natural reaction is to click the service location
• [x] IDEA / expectation: Referrals go to a central email, not the user email
• [x] edit your own service profile page
• [x] user profile pages need styles - what if we just had anchor tags on the service pages?
• [x] enter date in search field with mm/dd/yyyy and it needs to be less fuzzy
• [x] IDEA: alphabetized search results? going to rank in search result order, for now
• [ ] if a user has a patient they are working with and they are edited by someone else, do they get a notification? example: what if someone gets a new job and it is entered, would they get a notice?
• [ ] if a patient changes eligibility status (due to changing income, household, etc.) and resulted in a change of information from another service, send a notification to Access Now if they are working with that patient
• [ ] have a category that says “recently edited by someone else”

  Day 5

Care-a-van

• [x] homepage lists are a bit of visual clutter: definitely would want to see date of birth - they have quite a few patients with the same name
• [ ] homepage lists: show in alphabetical order unless the list is temporal-based
• [x] homepage list: incoming & outgoing referrals are a bit confusing
• [ ] when someone completes a referral, the referring clinic doesn't see a notification

[mapsam]

Created constants for "Years at current employer", as feedback from Kim at Mosby. Two questions:

1. This results in a data type change in the models, from Integer to String - should I update that and migrate @esmithayer?
2. What should the choices be? Kim mentioned making it simple, like "less than a year", "between 1 and 2 years" and "more than two years" ... here's what we have currently

TIME_AT_CURRENT_EMPLOYER = [
    ("",         ""),
    ("OWN",      _("Less than 1 year")),
    ("RELATIVE", _("1 to 2 years")),
    ("HOMELESS", _("More than 2 years"))
]

[mapsam]

Updated dropdown constants (still require "OTHER" option added in models.py)

PHONE_DESCRIPTIONS = [
    ("",         ""),
    ("CELL",     _("Cell phone")),
    ("HOME",     _("Home phone / landline")),
    ("WORK",     _("Work number")),
    ("RELATIVE", _("Relative's phone number")),
    ("OTH",      _("Other"))
]

ADDRESS_DESCRIPTIONS = [
    ("",         ""),
    ("OWN",      _("Personal address / own or rent")),
    ("RELATIVE", _("Relative's address")),
    ("HOMELESS", _("Homeless shelter address")),
    ("OTH",      _("Other"))
]

Let's add FRIEND house and rename HOMELESS to SHELTER

[mapsam]

Many-to-one forms can now have conditionally displayed fields by adding a new manyToOne parameter to the patient_details.html file:

{ target: "phone_numbers-X-number_description", child: "phone_numbers-X-number_description_other",
    type: "equals", comparator: "OTH", manyToOne: true},

The field requires an X to be replaced by a count number for selecting each of the elements.

[mapsam]

This phrasing should change since VCC is not technically insurance

[mapsam]

Show that changes need to be saved, make save button more visually apparent!

[mapsam]

Many bug fixes coming in #257 and #251!

:dancer: :dancer: :dancers: :dancer: :dancer: :clap:

[mapsam]

Working on fuzzy search integration with Fuse.js - we have access to parameters used in the search algorithm that allows us to control the "fuzziness" of it.

Right now you can have the search results return the index location of the matched search, which means we might be able to build a "bolded search match" into the results. Will post here if I get to that point.

[mapsam]

Looks like highlighting isn't a feature yet, but maybe we can build our own implementation?

https://github.com/krisk/Fuse/issues/6

[jeancroy]

May I interest you in FuzzySearch ? It has highlighting, as well as multiple word support (like out of order word or different word match different fields)

Syntax is similar and a demo is available here

[mapsam]

Nice, will take a look @jeancroy