search

codeforamerica / srtracker

Open311 Service Request Status Site
BSD 3-Clause "New" or "Revised" License
20 stars 23 forks source link

Bug report, OPEN311_SERVER needs http:// in the string. #22

Closed h4ck3rm1k3 closed 12 years ago

h4ck3rm1k3 commented 12 years ago

Hi there, I found that the preconfigured server : OPEN311_SERVER = 'localhost:5000' from the commit here https://github.com/codeforamerica/srtracker/commit/41bd8d19164a3654d49ceacb9a30657853c992b9#L0R8

patch is here : https://github.com/h4ck3rm1k3/srtracker/commit/4696bd30563771b10860d63f7c9c63373442496e

does not work, I needed to change that to http://localhost:5000 otherwise the requests lib failed to send proper http.

see my blog post about it. http://fmtyewtk.blogspot.de/2012/08/python-requests-get-string-corrupted.html

thanks, mike

Mr0grog commented 12 years ago

Thanks for the catch, Mike! The app is intended to always be run with a local configuration, so that constant is only used as a fallback of last resort—I guess I never ran it with no config after making the change.

If you make a pull request for just this issue, I'll be happy to merge it in.