codeforamerica / srtracker

Open311 Service Request Status Site
BSD 3-Clause "New" or "Revised" License
20 stars 23 forks source link

wrong call for "url_for" #24

Closed h4ck3rm1k3 closed 12 years ago

h4ck3rm1k3 commented 12 years ago

Another call to a function with the wrong parameters, I wonder if the code was ever run?

Patch here: https://github.com/h4ck3rm1k3/srtracker/commit/37d438b8d88d972ee3ea8d88b872304e4b604b36

Code trackback :

Traceback (most recent call last):
  File "/usr/share/pyshared/flask/app.py", line 874, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/share/pyshared/flask/app.py", line 864, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/usr/share/pyshared/flask/app.py", line 861, in wsgi_app
    rv = self.dispatch_request()
  File "/usr/share/pyshared/flask/app.py", line 696, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/mdupont/experiments/codeforamerica/srtracker/app.py", line 102, in redirect_request
    return redirect(url_for('show_request', request_id))
TypeError: url_for() takes exactly 1 argument (2 given)
Mr0grog commented 12 years ago

Hey Mike, I think this issue was actually created by one of your commits that actually hasn't been merged into this repo at all yet. I've highlighted it here: https://github.com/h4ck3rm1k3/srtracker/commit/7b2a98d4385b5d16bf38d98a5be5176b93f8f9bf#commitcomment-1707568

h4ck3rm1k3 commented 12 years ago

great! thanks. Sorry 'bout that.