search

codeforamerica / srtracker

Open311 Service Request Status Site
BSD 3-Clause "New" or "Revised" License
20 stars 23 forks source link

call to the new service template, for issue 18 #28

Closed h4ck3rm1k3 closed 12 years ago

h4ck3rm1k3 commented 12 years ago

https://github.com/codeforamerica/srtracker/issues/18

h4ck3rm1k3 commented 12 years ago

I have updated the pr as requested.

Mr0grog commented 12 years ago

Mike, next time, please keep the original formatting of the file you're editing (in this case, service_request.css). I took care of cleaning it up, but it made the diff much harder to read.

h4ck3rm1k3 commented 12 years ago

good point, the formatting should be in a separate patch. the only change that was important there was one I applied earlier, https://github.com/h4ck3rm1k3/srtracker/commit/8de263df852feee8a62e00c46940ed459f88b446 Originally there was the class main content : .main_content { padding: 0 40px; }

and I created a new class main_content_indent too move it down, because the header was inside the top picture :

.main_content_indent { padding: 100px 40px; }

The previous version used a margin of 100px, but I moved that into padding, I guess the 40px y padding could have been inherited.

thanks, mike

On Wed, Aug 15, 2012 at 1:29 AM, Rob Brackett notifications@github.comwrote:

Mike, next time, please keep the original formatting of the file you're editing (in this case, service_request.css). I took care of cleaning it up, but it made the diff much harder to read.

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/srtracker/pull/28#issuecomment-7745751.

James Michael DuPont Member of Free Libre Open Source Software Kosova http://flossk.org http://flossk.orgSaving wikipedia(tm) articles from deletion http://SpeedyDeletion.wikia.com Contributor FOSM, the CC-BY-SA map of the world http://fosm.org Mozilla Rep https://reps.mozilla.org/u/h4ck3rm1k3