Mr0grog
commented
9 years ago Hmm… thinking through this more, the line between what’s reasonable for configuration here vs. what should just be a new template seems fuzzy to me. Here’s the footer as it exists today:
(It actually needs to be updated to have another link to “Developer Documentation”)
There’s only one item in the footer that doesn’t need customization: the CfA logo/link. Everything else needs to be customizable:
- The list of links (I guess an array of either dicts or tuples? for text + url)
- URL of the city homepage
- City seal/logo to use with above link
That seems like a lot of pretty narrow stuff to plug into a config file. The footer is already its own template (https://github.com/codeforamerica/srtracker/blob/master/templates/_footer.html), so maybe this is better as a template that should be overridden than as a bunch of config vars? I’m starting to get afraid of needing some kind of handbook for all the config vars that we could wind up with here!
(Speaking of template overriding, should we add some sort of support for that rather than just having deployments modify the content of the templates directory? E.g. template lookup paths that fall back to the built-in ones if nothing’s there.)
Any thoughts, @migurski, @daguar?
In support of #64.
It should be possible to customize the links and city seal in the footer. If left unset, we need to make sure there is no "+" before the CfA logo.