search

codeforamerica / srtracker

Open311 Service Request Status Site
BSD 3-Clause "New" or "Revised" License
20 stars 23 forks source link

Sr code filter2 #70

Closed tacaswell closed 11 years ago

tacaswell commented 11 years ago

Adds a drop down to the top of the page to select only a single SR type.

Mr0grog commented 11 years ago

Sorry I haven't had a chance to take a look at this yet. Trying to make some time to get to it before the end of the week!

tacaswell commented 11 years ago

no worries

Mr0grog commented 11 years ago

Ok, I really like the idea of this, but I'm not sure shoving a form between the "Recently Updated Service Requests" and the actual list of requests quite feels right—it's a little disruptive when reading down the page and I think it disconnects the header from the content it's describing a little too much. Maybe it's just the huge blue "filter" button, though. Not sure I have a better approach in mind, though :\ Any ideas, @akit?

screen shot 2013-06-30 at 11 07 17 pm

I'll make some other inline notes on the code.

Mr0grog commented 11 years ago

@akit just sent me this, which I think is pretty nice: sr_filter3a

If you want to implement it, @tacaswell, go for it, otherwise I'll merge this in and then add that styling. Let me know, otherwise I might try and do it later tonight!

tacaswell commented 11 years ago

I am swamped with other stuff so it is unlikely I would be able to get to it tonight.

On Tue, Jul 23, 2013 at 6:55 PM, Rob Brackett notifications@github.comwrote:

@akit https://github.com/akit just sent me this, which I think is pretty nice: [image: sr_filter3a]https://f.cloud.github.com/assets/74178/845810/21f33aee-f3f3-11e2-9462-ca5d91480766.png

If you want to implement it, @tacaswell https://github.com/tacaswell, go for it, otherwise I'll merge this in and then add that styling. Let me know, otherwise I might try and do it later tonight!

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/srtracker/pull/70#issuecomment-21454940 .

Thomas Caswell tcaswell@gmail.com

Mr0grog commented 11 years ago

Closing this in favor of #73, which has the UI fixes. @tacaswell, feel free to comment if you have any concerns on it, otherwise I'll merge tomorrow (Monday) morning.

Mr0grog commented 11 years ago

Hey, @tacaswell, I've also made you a collaborator on this repo, so feel free to work on any branches directly in codeforamerica/srtracker if you'd like! (Including, of course, the branch for #73)