codeforanchorage / realtime-bus-sms

Text back current arrival time for buses given a texted in bus stop number for People Mover. AddressLookup branch would allow texting "Arctic and Fireweed"
https://bus.codeforanchorage.org
14 stars 10 forks source link

Watson #107

Closed mark-meyer closed 7 years ago

mark-meyer commented 7 years ago

This is the Watson branch that is currently running on the server with a few cleanups and with the alternate geocode approach merged in (which is running on the plugin server). I am heading out of town at the end of next week and will be pretty out of touch for a few weeks. Between now and then I can make any changes/adjustments if anyone has comments.

tescher commented 7 years ago

Is this running in production or test?

Tim Escher tim@eschers.com 608 432 5799

On Jan 12, 2017 3:20 PM, "Mark Meyer" notifications@github.com wrote:

This is the Watson branch that is currently running on the server with a few cleanups and with the alternate geocode approach merged in (which is running on the plugin server). I am heading out of town at the end of next week and will be pretty out of touch for a few weeks. Between now and then I can make any changes/adjustments if anyone has comments.

You can view, comment on, or merge this pull request online at:

https://github.com/codeforanchorage/realtime-bus-sms/pull/107 Commit Summary

  • testing some loggin options
  • better 404 repsponse for HTML Version
  • first attempt at hooking up Google Analytics
  • first attempt at hooking up Google Analytics
  • first attempt at hooking up Google Analytics
  • experimenting with various ways of sending data to Google Analytics
  • add http response code to log
  • Moved input test from lib to routes to allow easier identification of actions
  • cleaning up
  • hacking a little on Watson integration
  • cosmetic changes
  • added watson to sms requests too
  • massaging user input
  • adding better comments
  • Watson
  • Logging using Winston Transports to allow flexible logging options
  • Logging using Winston Transports to allow flexible logging options
  • Forgot to add new view files
  • Added Response Time at event values in Google Analytics since it wasn't being used
  • Merge branch 'master' into logging
  • merged loggin branch back in
  • Cleaned up middleware to make flow a little easier to see
  • added some debuging logs to help see repsones
  • added Code for Anchorage tracking code Google Analytics
  • Updated Version of LowDB needs default objects.
  • Forgot to updat both lowDB logs for new versions
  • better handling of objects in log int
  • fixed merge conflict with logging branch
  • moved analytics tracking code to lib/config.js. Fixed log transport so logged objects are formatted better.
  • merged changes from logging
  • Moved Watson workspace ID of lib/config.js
  • will be adding cookies to track sessions
  • Fixed bug in console logging formatter
  • Merge branch 'logging' into addCookie
  • Added UUID for tracking new/existing users in Google Analytics
  • switched GA Tracking Code back to Code For Anchorage's
  • Merged in Logging code
  • Pushed Watson Context as a JSON stringified strin in a cookie to allow stateful responses
  • Watson's intents aren't the best choice for deciding how to respond. Added and action to the context
  • added action to context to help with conversation threads
  • typo fix
  • changed module style for logging
  • decoupling logging from the rest of the application
  • Fix Typo
  • Fix Typo
  • debug test
  • remove debug test
  • moved the lowDB transport to it's own file - it seems very specific to the bus app
  • required libraries for lowDB log transport
  • Merged Branch to make logging more independent of the bus app
  • merge changes from logging branch
  • Improved error messages that are returned to the user to make them more watson-like
  • fixed user input not properly encoded for search string
  • Merged logging which fixes unencoded input in url string
  • Reenable Rollbar
  • Added catch for Google Geocoder errers
  • Cleaned up and removed unused requires from routes
  • Cleaned up and removed unused requires from routes
  • Cleaned up and removed unused requires from routes
  • Improved error checking in getStopsFromAddress
  • fixed some formatting
  • fix typos
  • Fixed bug where writing to lowDB fails on empty file
  • Fixed bug where writing to lowDB fails on empty file
  • Added some better comments for logger.js and app.js
  • Changed the test address in test_browserAddressEntry & test_smsAddressEntry to '5th Avenue and G street'. The previous address was '5th Avenue' for which Google's geocoder intermittently returns zero results causing the tests to fails
  • Changed the test address in test_browserAddressEntry & test_smsAddressEntry to '36th Avenue'. The previous address was '5th Avenue' for which Google's geocoder intermittently returns zero results causing the tests to fails
  • Fixed merge conflicts with master
  • Merge test stub for Google geocoder
  • Stop lowdb log from capturing pageviews, empty input, and Feedback events
  • fix comment typos
  • Move Google Analytics tracking code to env variable process.env.GOOGLE_ANALYTICS_ID
  • Move Google Analytics tracking code to env variable process.env.GOOGLE_ANALYTICS_ID (take two)
  • Stop lowdb log from capturing pageviews, empty input, and Feedback events
  • Set feedback action on inclomg web feedback
  • Fixed problem where UUID was not set on first request from new users
  • Added UUID cookie before logs so first request from new user gets cookie in time to log request.
  • Move Watson workspace ID to process.env.WATSON_WORKPLACE_ID
  • resolved merge conflicts with latest master
  • Made asking Watson the last resort. Stop numbers and address should be handled without calling Watson
  • Added watson routines for direct url requests allowing bookmarked urls to work again
  • Added new jade views to help render both ajax and non-ajax views
  • Cleaned up the askWatson code and fixed some typos.
  • return error when google geocoder returns error
  • remove debug console log
  • Move to newer node-geocode mode which returns empty array instead of error when no results are found
  • Fixes issues where route numbers are not sent with sms stop lookups
  • Added Service Exceptions check for holidays on stop lookups
  • Added simple Rollbar notifications for logger.error() occurance
  • Prevents HEAD requests from being logged to Google Analytics to prevent site-checer script from being logged as a user
  • Merged latest logging branch
  • change cookie order
  • change cookie order back
  • Fixed issus where UUID is not available on first session
  • Merge branch 'logging' into watson
  • Makes the no stops found message look better on sms
  • Fixed punctuation on no stop found message
  • Fixed punctuation on bad stop number message
  • New Geocoder approach
  • New Geocoder approach
  • Use Geocoder location types to determine if we found a usable location
  • changed mock geocode data in test to reflect new geocode routine
  • changed mock geocode data in test to reflect new geocode routine
  • Checks Service Exceptions and responds with no serive message on holidays
  • trying node version of updating gtfs data
  • Merge branch 'geocode-adjust' into watson
  • Create stop_number_lookup.js from raw GTFS text files
  • Merge branch 'updateGTFS' into watson which returns results for frequently requested locations such as "Downtown Transit Center".
  • Allow finer grained errors in logger. It can now take a range on inputs including en Error object, message, or either with a custom object to provide context
  • clean up errors and warnings

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/codeforanchorage/realtime-bus-sms/pull/107, or mute the thread https://github.com/notifications/unsubscribe-auth/ACcF3Is1DtanDXYEtTLJT-c455l0ERWxks5rRpkDgaJpZM4LiPvU .[image: Web Bug from https://github.com/notifications/beacon/ACcF3Llb2QZn7lM3niIRM0AmqFtHNBsaks5rRpkDgaJpZM4LiPvU.gif] {"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/codeforanchorage/realtime-bus-sms","title":" codeforanchorage/realtime-bus-sms","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/ 143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png"," avatar_image_url":"https://cloud.githubusercontent.com/ assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png ","action":{"name":"Open in GitHub","url":"https://github. com/codeforanchorage/realtime-bus-sms"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Watson (#107)"}],"action":{"name":"View Pull Request","url":"https:// github.com/codeforanchorage/realtime-bus-sms/pull/107"}}}

mark-meyer commented 7 years ago

Both, kind of — production has been running a version without the new geocode approach for a couple weeks. The test is running it with the new geocode code. This has the two merged.