Pictures are Missing - Githubissues

codeforbirmingham / Open-Disclosure

Understanding Alabama Campaign Finance Data

http://www.codeforbirmingham.org/Open-Disclosure/

17 stars 6 forks source link

Pictures are Missing #116

Open davidgrieser opened 8 years ago

davidgrieser commented 8 years ago

For candidates that do not have their initials, their image is not loading.

Example:

CLAY DANIEL SCOFIELD STATE SENATOR

Current Link - http://www.legislature.state.al.us/graphics/senatepics/scofield_c.jpg

Actual Link - http://www.legislature.state.al.us/ALISWWW/Senate/Senator%20Pictures/Scofield_9.jpeg

Looks like someone moved the picture assets and did not setup redirects. However, we cannot use the above example directly as Scofield is a Senate member.

mwleeds commented 8 years ago

This turned out to be more complicated than it appeared. Not only did the picture locations change (and we weren't checking for updates from Google regularly) but the code in CallCivicInfoAPI.py to match people in Google's data with people in alabamavotes.gov data also needs work.