search

codeforboston / cambridge_energy_app

EnerSave is designed to help and encourage Cambridge residents to reduce their electric bills.
https://www.enersaveapp.org/
MIT License
33 stars 25 forks source link

Fix for issue #263 (Why do you need the Bill Due Date) #302

Closed kvotolato3 closed 7 years ago

kvotolato3 commented 7 years ago

This PR renames "Date Bill is Due" to "Bill Date" in the Add Bill view, as well as the rspec test.

mzagaja commented 7 years ago

My general thought when labeling it this is that you might have two separate items on the bill: the month the bill was for and the month the bill was due (i.e. my credit card bill arrives on March 15th, but is due April 15th, and covers charges from February 15th to March 15th). So realistically we have two potential months that the bill might be placed in depending on when they get it (unless it's due like a week after you get it?). I'm not sure how Eversource handles this or if it's an issue. But I thought "bill due date" disambiguated these scenarios. Would another solution simply be to reduce this to "bill month" since the actual day of the month probably is not important?

kvotolato3 commented 7 years ago

I see what you mean here. There is the Billing Date, the Bill Due Date and then there is also the last meter read date, which is also important.