search

codeforboston / cliff-effects

Cliff effects guidance prototype (archived)
https://codeforboston.github.io/cliff-effects/#/
MIT License
30 stars 64 forks source link

add react select (originally from josephdlawson21-add-react-select). Fixes #892 #1034

Closed turnerhayes closed 5 years ago

turnerhayes commented 5 years ago

No idea why this is passing CI and the original PR (#977) was not...

turnerhayes commented 5 years ago

Fixes #892.

knod commented 5 years ago

It's because the package-lock wasn't updated, I think.

knod commented 5 years ago

We'll have to try to fix the styles on here after merging this.

turnerhayes commented 5 years ago

@knod Did a merge that changed Household.js--would appreciate a review of the new merge!

turnerhayes commented 5 years ago

@dylanesque (or anybody else)--I would like to have at least 2 approvals on this before I merge, since I didn't write the original.

knod commented 5 years ago

Doesn't look like it broke anything to me and the code styles are pretty close to what we're establishing. I stand by my approval!