codeforboston / cliff-effects

Cliff effects guidance prototype (archived)
https://codeforboston.github.io/cliff-effects/#/
MIT License
30 stars 64 forks source link

Cleans '/src/utils' through 'interpolation.js'. #1018. Also #708. #1037

Closed knod closed 5 years ago

knod commented 5 years ago

@dylanesque : I don't see a forUpdate function, just an object. Are we talking about the same thing?

turnerhayes commented 5 years ago

@dylanesque are you referring to this?:

const convertForUpdate = function ({ name, route, ...otherProps }) {
   let forUpdate = {
     ...otherProps,
     route: route || name,
   };
   return forUpdate;
 };  // End convertForUpdate()
dylanesque commented 5 years ago

@dylanesque are you referring to this?:

const convertForUpdate = function ({ name, route, ...otherProps }) {
   let forUpdate = {
     ...otherProps,
     route: route || name,
   };
   return forUpdate;
 };  // End convertForUpdate()

That's what I meant, but the quoted code you have above doesn't match at all what I'm seeing in the PR, namely:

   let forUpdate = {
       return forUpdate;     
 };
 export { convertForUpdate };   export { convertForUpdate };
knod commented 5 years ago

@dylanesque : that's just github skipping lines - it avoids showing the whole file and concentrates on what's been changed. If you see, there's a line highlighted in blue that has icons at the left edge. If you click on those, it'll expand to show more of the code. You can also click 'view' for the file and see the new version in full.