search

codeforboston / cliff-effects

Cliff effects guidance prototype (archived)
https://codeforboston.github.io/cliff-effects/#/
MIT License
30 stars 64 forks source link

Deploy preview for PRs #657

Closed zhujinxuan closed 6 years ago

zhujinxuan commented 6 years ago

Do you want to request a feature or report a bug? feature

What's the expected behavior? After submitting a PR, a bot shall deploy the site in a PR-specific url for previewing the changes made by PR.

Recently I submit a PR in slateJS. I find that they are using netlify.com; So each time after submitting a commit, then it will use netlify.com to deploy a example-site based on that PR (like https://github.com/ant-design/ant-design/pull/11189#issuecomment-402970977). When new commits comes to the PR, the deployed example will be automatically updated.

Then we can easily understand that changes made by the PR by viewing the provided deploy preview.

zhujinxuan commented 6 years ago

The deploy preview is very easy to set. Just go the netifly.com, tell

  1. which repo want to deploy preview
  2. which cmd is used to generate deploy
  3. the directory path (build/ in this project) to store index.html for deploy.
knod commented 6 years ago

If you feel up for setting it up, I say go for it! It sounds like a great tool :)

zhujinxuan commented 6 years ago

@knod Hi, I need to be a member of codeforboston organization to set-up netifly

As the image below, I need to grant permission as an organization member.

screen shot 2018-07-13 at 11 03 02 am
knod commented 6 years ago

Shoot! Didn't realize no one had added you yet. Will do now.

knod commented 6 years ago

Ah, sorry, I didn't quite understand the requirement. We'll have to talk to the core team at CfB to see how they think this can work.