search

codeforboston / cliff-effects

Cliff effects guidance prototype (archived)
https://codeforboston.github.io/cliff-effects/#/
MIT License
30 stars 64 forks source link

Examine how blocking is happening in src/components/prompts/ReactRouterLeaveListener.js #946

Closed knod closed 6 years ago

knod commented 6 years ago

Do we need the function or can the parent just pass in whether leaving is being blocked or not? https://github.com/codeforboston/cliff-effects/pull/922#pullrequestreview-169101378

knod commented 6 years ago

Eh, it's working. We can put it on hold and close the issue for now.

knod commented 6 years ago

Found what I think is a pretty quick fix for it, so I may just take a shot.

knod commented 6 years ago

Nvm, I've been blind this whole time. This feature is being much more interesting than I thought.