codeforboston / cliff-effects

Cliff effects guidance prototype (archived)

https://codeforboston.github.io/cliff-effects/#/

MIT License

30 stars 64 forks source link

Fixes #961 - different abstraction for user message, take 1 #962

Closed knod closed 5 years ago

knod commented 6 years ago

961

turnerhayes commented 5 years ago

Looks good, but I wanted to put a discussion question out there; is this premature abstraction? It seems it's only currently being used in one file; are we sure this is something that's going to be reused?

knod commented 5 years ago

We do plan to re-use it as we move forward. Also, It seemed like a more concrete abstraction to me. We also discussed that it could use a better name.