solution to Spouse/member dropdown not fully changing on selection of item #892

codeforboston / cliff-effects

Cliff effects guidance prototype (archived)

https://codeforboston.github.io/cliff-effects/#/

MIT License

30 stars 64 forks source link

solution to Spouse/member dropdown not fully changing on selection of item #892 #977

Closed josephdlawson21 closed 5 years ago

josephdlawson21 commented 5 years ago

This is my solution to issue #892. there was an issue with Semantic UI and i replaced the Dropdown component with the react-select package. had to make a new callback because the data returned from the dropdown was different.

knod commented 5 years ago

Sorry we misunderstood the situation yesterday. I think for this we should update the package-lock.json since the package.json is actually changing. It's a shame we have to add a whole new lib just for this one component. You said semantic-ui-react has an issue for this. Maybe we can link this lib in there. It may help them along.

Other than that, the style doesn't match ours, but that can probably be tweaked later.

knod commented 5 years ago

From what I can see, an inaccurate p-l is the reason the tests are failing. Which may be another note to add to #929.

knod commented 5 years ago

@turnerhayes , @dylanesque , or anyone else, this one needs to be taken up and completed.

knod commented 5 years ago

Taken over by #1034