search

codeforboston / cliff-effects

Cliff effects guidance prototype (archived)
https://codeforboston.github.io/cliff-effects/#/
MIT License
30 stars 64 forks source link

Add node version checking script. Fixes #983 #992

Closed turnerhayes closed 5 years ago

turnerhayes commented 5 years ago

TBD: all the places to run this

turnerhayes commented 5 years ago

For some reason, this didn't seem to show any link to #983

turnerhayes commented 5 years ago

Another question to consider; do we want to do exact version match? Or accept higher versions/different minor/patch versions? That is, if our current node version is set to v10.13.0, should we warn if the user is on 10.13.4? 10.15.0? 12.0.0?

turnerhayes commented 5 years ago

Added check to pre-commit and lint. Keeping version checking to exact match.

knod commented 5 years ago

It's weird. I'd think on commit you'd get two messages, since it also lints, but you only get one.

turnerhayes commented 5 years ago

I think that's because the pre-commit hook runs eslint --fix, rather than npm run lint