search

codeforboston / communityconnect

MIT License
24 stars 61 forks source link

Feat/map update #383

Closed Leftere closed 5 years ago

Leftere commented 5 years ago

Issue #382

I have restyled the Google map to fit our design, I also got rid of lots of unnecessary default labels and icons to improve visual aspect.

My plan is to give each institution a uniq icon so that the users knows what they click on.

johnpyp commented 5 years ago

Screenshots of the change: https://imgur.com/a/C1w75Tx

johnpyp commented 5 years ago

If that is your SSH key, I'd recommend changing it right away. There are bots that scrape github for things like passwords, other credentials, and ssh keys, so they could use it to access your github or anything your ssh key is authenticated with.

RajChaudhry commented 5 years ago

I don't have any review comments that haven't been left by others. When you say "give each institution a unique icon" do you mean each resource? Because there are currently around resources, 100, and as we grow there are gonna be a lot more. That'll be tough to sustain and onboard.

Leftere commented 5 years ago

Yes, each resource.

Leftere commented 5 years ago

Ok guys, I think I fixed all your comments and Im ready to merge this. Let me know If I need to do anything.

For some reason I'm under impression that I need to close this pull request and create a new one. I am sure I am wrong though

RajChaudhry commented 5 years ago

Ok guys, I think I fixed all your comments and Im ready to merge this. Let me know If I need to do anything.

For some reason I'm under impression that I need to close this pull request and create a new one. I am sure I am wrong though

@Leftere It doesnt seem like you pushed your changes to this branch. Are you sure you added + committed all the right files? And that you pushed to the feat/map-update branch?