codeforboston / communityconnect

MIT License
24 stars 61 forks source link

Feat/eslint #384

Closed johnpyp closed 5 years ago

johnpyp commented 5 years ago

Description

Adds eslint to consistently format codebase and enforce code quality in various areas.

Fixes #378

Motivation and Context

There was inconsistent code style and some bad practices throughout the codebase. This change attempts to solve that with stricter linting and formatting requirements.

Type of change

johnpyp commented 5 years ago

Up to date with the current development branch.

Includes:

Other changes that could either go into this PR or a new one:

davidholyko commented 5 years ago

i think its good to go. there are some small things here and there that we can break into smaller PRs for the future but this is a big step in the right direction

johnpyp commented 5 years ago

Awesome. It would be cool if we could get this merged into development before the next meeting, because other changes or PRs made before then will have a lot of merge conflicts to deal with.

davidholyko commented 5 years ago

i would ping raj and have him approve/merge it in

johnpyp commented 5 years ago

Sounds good. @RajChaudhry Do you think this is good to merge?

johnpyp commented 5 years ago

Added lint-staged and husky to fix #388

johnpyp commented 5 years ago

Added trailing commas to prettier config (already present in airbnb config, but was overridden by the prettier eslint plugin).

RajChaudhry commented 5 years ago

Shit forgot to write comments before merging, but the linting looks great! Thanks for setting it up JP!