Closed johnpyp closed 5 years ago
Up to date with the current development branch.
Includes:
Other changes that could either go into this PR or a new one:
resource
describes many different things, including the plural (array) and singular version of it.i think its good to go. there are some small things here and there that we can break into smaller PRs for the future but this is a big step in the right direction
Awesome. It would be cool if we could get this merged into development before the next meeting, because other changes or PRs made before then will have a lot of merge conflicts to deal with.
i would ping raj and have him approve/merge it in
Sounds good. @RajChaudhry Do you think this is good to merge?
Added lint-staged and husky to fix #388
Added trailing commas to prettier config (already present in airbnb config, but was overridden by the prettier eslint plugin).
Shit forgot to write comments before merging, but the linting looks great! Thanks for setting it up JP!
Description
Adds eslint to consistently format codebase and enforce code quality in various areas.
Fixes #378
Motivation and Context
There was inconsistent code style and some bad practices throughout the codebase. This change attempts to solve that with stricter linting and formatting requirements.
Type of change