codeforboston / communityconnect

MIT License
24 stars 61 forks source link

WIP feat/code-quality: Code Quality Improvements #390

Closed johnpyp closed 5 years ago

johnpyp commented 5 years ago

Description

This PR is meant to include a few different changes meant to improve code quality across the codebase (in the same spirit as the linting and formatting PR).

List of changes (subject to change):

Fixes #389 Fixes #328

Outstanding Issues

Code quality is important to maintain to ease development friction for existing contributors, as well as helping new contributors on-board quickly.

Type of change

acharliekelly commented 5 years ago

Hey, maybe you want to split this into 2 PRs, one for each issue

acharliekelly commented 5 years ago

Is it possible to put the Map Toggle button in a separate PR? I think the other issues are close enough not to need their own PRs, but the more distinct PRs you have, the easier it will be to fix merge conflicts later