codeforboston / communityconnect

MIT License
23 stars 61 forks source link

dependency updated bashing needed #421

Closed jaime-varela closed 2 years ago

jaime-varela commented 3 years ago

Description

Moved to use google-map-react dependency. This change is to address issue #392 . I've bashed quite a bit using my google maps API key (the existing one in the codebase is expired) but am not familiar with all the expected behavior.

The UI should look the same as before. Effort was spent to keep the same map behavior as the previous dependency.

Fixes #

392

Motivation and Context

The reacts-google-map dependency is no longer maintained and keeping it would have not allowed the app to use future google map features.

Type of change

jaime-varela commented 3 years ago

Not sure why my yarn.lock file was not synced to source. Will examine tonight.

jaime-varela commented 3 years ago

Not sure why my yarn.lock file was not synced to source.

I did submit a yarn.lock update but the deploy preview is using an older lock file with npm version 8. Will examine this sometime soon.