search

codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
8 stars 25 forks source link

Adding a new chart causes Recharts to fail in both new branch and master branch - PR 103 #108

Open jkoren opened 7 months ago

jkoren commented 7 months ago

Something strange is occurring which pertains to PR 103

See comment:

We need to check on the graphs/charts. When those are back to the way they were, we can merge. Originally posted by @plocket in https://github.com/codeforboston/home-energy-analysis-tool/issues/103#issuecomment-1811741224

As a test, I created a new repo with epic stack and recharts. jkoren/epic-stack-with-recharts. A simple test scatter graph displayed. So it all worked ok.

Then I created a branch on that repo: revising-charts-for-HEAT

I brought over the three graphs from [PR 103(https://github.com/codeforboston/home-energy-analysis-tool/pull/103) into that new branch.

  1. Heat Load
  2. Standard Deviation of UA
  3. Whole Home UA Comparison

I called them from root.tsx as below. 

  <Document nonce={nonce}>
    <SimpleScatterChart />
    <HeatLoad />
    <StandardDeviationOfUA />
    <WholeHomeUAComparison />
  </Document>

The 3 new graphs did not work. The test scatter graph that had worked did not work now either.

here’s the strange part: I switched back to the master branch, and the test scatter graph no longer worked there either, even though I made no changes to the master branch.

It seems somehow the Epic stack or Rechart or both got corrupted.