search

codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
7 stars 25 forks source link

Docker rules engine issue 116 #194

Closed ethanstrominger closed 1 week ago

ethanstrominger commented 1 month ago

See issue #116

Docker will only process sub directories so it needed to be above rules-engine and heat-stack directory.

I created a copy of the original Dockerfile to /Dockerfile-original to make comparison easier.

thadk commented 1 month ago

Hi @ethanstrominger thanks so much for this!

I just want to note that though we didn't get to check the final insertion-into-docker step, hypothetically in this PR from 10 days ago https://github.com/codeforboston/home-energy-analysis-tool/pull/176 gets the rules-engine built python egg into the GitHub Action (GHA) artifacts. Then the vitest uses it from the GHA artifacts. I figured we could get that into docker as it was building.

Which approach or mix of approaches do you think we should ultimately use? Thankfully, with both these "new" ways, whatever rules-engine branch version should exactly match the deployed one which was our worry with our first other discarded solution to this.

Sorry I didn't get back to update that original issue with the progress 🫤!

We can totally merge in the docker way: my only tiny reservation is on extra divergence from our docker deploy template which may yet get new features upstream. There is not any automated upgrade process though so just a bit of extra hand merging later. Also we might need to double check the .dockerignore changes.

ethanstrominger commented 4 weeks ago

Thad - Whatever you think is best. I don't know enough about the other way to judge. With the docker approach I can test without checking into github.

thadk commented 4 weeks ago

That's a great point about being able to test locally! Let's use this.