codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
8 stars 25 forks source link

Distinguish billing period seasons #71

Closed mciethan closed 9 months ago

mciethan commented 9 months ago

Fixes #11

To do:

mciethan commented 9 months ago

I could use some help getting the lint to pass. When I run isort locally in my virtual environment, there are no issues, but when I push here, the lint checks fail with generic error messages about the imports being incorrectly sorted. Otherwise, this should be set to merge

alanisaac commented 9 months ago

I could use some help getting the lint to pass. When I run isort locally in my virtual environment, there are no issues, but when I push here, the lint checks fail with generic error messages about the imports being incorrectly sorted. Otherwise, this should be set to merge

I wonder why? Are you using a clean venv with the requirements installed from requirements-dev.txt? Locally:

$ git checkout avgnonheat
Switched to a new branch 'avgnonheat'
Branch 'avgnonheat' set up to track remote branch 'avgnonheat' from 'origin'.
$ cd rules-engine
$ isort .
Fixing C:\git\alanisaac\home-energy-analysis-tool\rules-engine\tests\rules_engine\test_engine.py
Fixing C:\git\alanisaac\home-energy-analysis-tool\rules-engine\tests\rules_engine\test_examples.py
Skipped 2 files
$ git status
On branch avgnonheat
Your branch is up to date with 'origin/avgnonheat'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   tests/rules_engine/test_engine.py
        modified:   tests/rules_engine/test_examples.py

no changes added to commit (use "git add" and/or "git commit -a")
mciethan commented 9 months ago

My issue was that I was running isort from the root directory instead of cd'ing into rules-engine. That check now passes, and I also merged main into this branch + resolved a merge conflict to make these commits compatible with the latest version of main