search

codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
8 stars 25 forks source link

Attempting to fix issue uncovered by example 4 #86

Closed alanisaac closed 8 months ago

alanisaac commented 9 months ago

In the session on 2023-09-26, @axiomizer uncovered a possible issue with the ua calculation by incorporating example 4. Running pytest, the output is:

FAILED tests/test_rules_engine/test_examples.py::test_ua[example-4] - assert 928.9943203193295 == 913 ± 1.0e+00

The 913 value comes from the Whole Home UA value from the spreadsheet, but the rules engine is coming up with ~928.

axiomizer commented 9 months ago

The fix for Feldman was to pass in the balance point sensitivity. Example 4 is still failing; it seems to have the wrong sensitivity, because the balance point is 62.5 but the sensitivity is 2. Since the balance point starts at 60, it should not be possible to reach 62.5 by increments of 2.