search

codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
8 stars 25 forks source link

Added makefile to rules engine #91

Closed alanisaac closed 8 months ago

alanisaac commented 8 months ago

I'm finding it's somewhat difficult to share pre-commit hooks in a project. In lieu of that directly, this makefile consolidates everything into one step, so developers do not have to remember all the commands in CI.

Run make all from the rules-engine folder and it will check everything that CI checks.

jkwan2011 commented 8 months ago

Should we update CI to use Makefile to remove duplication?

alanisaac commented 8 months ago

Should we update CI to use Makefile to remove duplication?

Yeah, that's a good idea.

alanisaac commented 8 months ago

@jkwan2011 done

alanisaac commented 8 months ago

Nit: Rename to Makefile by convention

TIL: https://stackoverflow.com/a/12686411

Normally you should call your makefile either makefile or Makefile. (We recommend Makefile because it appears prominently near the beginning of a directory listing, right near other important files such as README.)