search

codeforboston / jobhopper

Jobhopper helps planners and career coaches analyze patterns of career-changers to inform policy and planning decisions. Contact jobhopper@codeforboston.org if you have issues you would like to report.
MIT License
11 stars 26 forks source link

Iss 311 #350

Closed jedpittman closed 3 years ago

jedpittman commented 3 years ago

closes #311

LewisStaples commented 3 years ago

I confirm that the errors described in the issue are corrected. All changes in the files appear directly related to the issue description. I confirm that all tests run successfully on my machine.

Please note that Github has identified two warnings in frontend/src/ui/Results/Results.stories.tsx

(1) 'Provider' is defined but never used (2) 'createStore' is defined but never used

I see that both are imported. The code that uses them has been commented out, therefore I suggest removing the two import statements, and all code that uses them. (I saw no issues when I did that and tested it on my local machine)

jedpittman commented 3 years ago

Thanks for the review @LewisStaples ; merging this code in now.