codeforboston / jobhopper

Jobhopper helps planners and career coaches analyze patterns of career-changers to inform policy and planning decisions. Contact jobhopper@codeforboston.org if you have issues you would like to report.
MIT License
11 stars 26 forks source link

feature/treemap polish #357

Closed alexjball closed 3 years ago

alexjball commented 3 years ago

Closes #353, #333, #349

jedpittman commented 3 years ago

I'm merging this as is @alexjball . However, the only thing I'm not sure about is the .02 percent limit. I seem to find cases where those are in the treemap....but not worth keeping out all of the other good stuff so I am merging and we can fix any residual as needed (if needed).

alexjball commented 3 years ago

Thanks for the review @jedpittman could you clarify what you expect vs what you see with the limit? The table only shows above 0.2%, the treemap should show all transitions.

jedpittman commented 3 years ago

ok great. If the treemap should show all then we're all set. No further work needed.

On Thu, Apr 8, 2021 at 3:57 PM alexjball @.***> wrote:

Thanks for the review @jedpittman https://github.com/jedpittman could you clarify what you expect vs what you see with the limit? The table only shows above 0.2%, the treemap should show all transitions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforboston/jobhopper/pull/357#issuecomment-816125998, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMD2CVDZA7ESE65FRSOHATTHYDBFANCNFSM42PSAVVA .