codeforboston / maple

MAPLE makes it easy for anyone to view and submit testimony to the Massachusetts Legislature about the bills that will shape our future.
https://mapletestimony.org
MIT License
44 stars 118 forks source link

global search - FrontEnd P1 #1199

Closed saltair3 closed 1 year ago

saltair3 commented 1 year ago

Summary

1172

Added global search bar in header - FRONTEND part 1

Checklist

Screenshots

Desktop view:

Screen Shot 2023-07-02 at 7 31 45 PM

Responsive/mobile view:

Screen Shot 2023-07-02 at 7 01 03 PM

Known issues

Full functionality requires #1175 and #1173

will fix formatting issues when in mobile view- see screenshot above - #1200

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 9:39pm
vercel[bot] commented 1 year ago

@hshareef9 is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

saltair3 commented 1 year ago

re prev commit:

uninstalled unnecessary package that I installed prev

rounded borders:

Screen Shot 2023-07-02 at 8 30 22 PM
saltair3 commented 1 year ago

Not ready for reviews. I need to do another commit.

tommagnusson commented 1 year ago

Not ready for reviews. I need to do another commit.

No worries! Perhaps for extra visibility we could mark this as a draft?

saltair3 commented 1 year ago

Desktop: signed in:

Screen Shot 2023-07-10 at 5 35 07 PM

signed out:

Screen Shot 2023-07-10 at 5 36 09 PM

Mobile:

signed in:

Screen Shot 2023-07-10 at 5 35 23 PM

signed out:

notice sign in button is red box in navBar -

Screen Shot 2023-07-10 at 5 37 37 PM

Issues

..will create tickets for these

dropdown pushes elements in navbar to right in both desktop and mobile.

Screen Shot 2023-07-10 at 5 39 48 PM

dropdown of signed in pushes down in mobile only

Screen Shot 2023-07-10 at 5 41 05 PM
saltair3 commented 1 year ago

Not ready for reviews. I need to do another commit.

No worries! Perhaps for extra visibility we could mark this as a draft?

Sure! That sounds great!